----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18733/#review36151 -----------------------------------------------------------
tests fail: Running com.cloud.upgrade.dao.DatabaseAccessObjectTest Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.139 sec <<< FAILURE! Running com.cloud.upgrade.dao.DbUpgradeUtilsTest Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.306 sec <<< FAILURE! Results : Tests in error: initializationError(com.cloud.upgrade.dao.DatabaseAccessObjectTest): Lcom/cloud/upgrade/dao/DatabaseAccessObject; com.cloud.upgrade.dao.DbUpgradeUtilsTest: Lcom/cloud/upgrade/dao/DatabaseAccessObject; Tests run: 3, Failures: 0, Errors: 2, Skipped: 0 - daan Hoogland On March 4, 2014, 4:13 p.m., Miguel Ferreira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18733/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 4:13 p.m.) > > > Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and Hugo > Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > Refactor DbUpgradeUtils > > - Move database access code to new class DatabaseAccessObject. This was > done to ease the effort of testing, since DbUpgradeUtils has a static API and > it is harder to mock static things with Mockito. > - Log exceptions even if ignored. > - Add unit tests for both DbUpgradeUtils and DatabaseAccessObject. > - DbUpgradeUtils.dropTableColumnsIfExist(...) no longer throws > CloudRuntimeException to make it consistent with the other methods in the > class. > > > Diffs > ----- > > engine/schema/src/com/cloud/upgrade/dao/DatabaseAccessObject.java > PRE-CREATION > engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java af23b87 > engine/schema/test/com/cloud/upgrade/dao/DatabaseAccessObjectTest.java > PRE-CREATION > engine/schema/test/com/cloud/upgrade/dao/DbUpgradeUtilsTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/18733/diff/ > > > Testing > ------- > > Ran all unit tests in eclipse. > Ran "mvn clean install". > > > Thanks, > > Miguel Ferreira > >
