> On Feb. 20, 2014, 9:50 a.m., Sebastien Goasguen wrote: > > Thanks for these tests. Please add apache license headers to all python > > scripts. > > Also use 127.0.0.1 as IP of the mgt host. > > Can you also start a wiki page to describe the tests and how to run them > > (i.e dependency on selenium etc..)
ok Yichi, looks like your other review depends on this. But this patch is not properly formatted. Did you use: git format-patch master --stdout > ~/patch-name.patch the process is described here: http://cloudstack.apache.org/developers.html you can upload a new patch to this review. - Sebastien ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18277/#review34991 ----------------------------------------------------------- On Feb. 19, 2014, 6:52 p.m., Yichi Lu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18277/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 6:52 p.m.) > > > Review request for cloudstack, Nitin Mehta, Parth Jagirdar, and Sebastien > Goasguen. > > > Repository: cloudstack-git > > > Description > ------- > > This is the initial check in. There are several directories: common, browser, > cspages, cstests/smoketests, cstests/regressiontests. > The browser directory is for browser selection. Currently only firefox is > used. > The common directory is for those shared modules. > I plan to create one module for every page. There will also be parent pages > and child pages (for instance, infrastructure page is going to have a lot of > child pages). > At this time I only have one test: login_logout_test, which has 9 individual > tests in it, one successful test, eight failed tests including some SQL > injection tests. Still missing are the tests for language options and domain > selection. > I decide to not use lib directory. It seems to me that lib is a JAVA (or C) > thing. So I copied Global_Locators.py to common directory. I'll use Parth's > code as much as I can. > I'll try to write each test for one purpose only. So login_logout_test is for > login page and logout. Obviously every test must have login and logout tests. > > > Diffs > ----- > > test/selenium/browser/firefox.py PRE-CREATION > test/selenium/common/Global_Locators.py PRE-CREATION > test/selenium/common/shared.py PRE-CREATION > test/selenium/cspages/loginpage.py PRE-CREATION > test/selenium/cstests/smoketests/login_logout_test.py PRE-CREATION > test/selenium/cstests/smoketests/smokecfg.py PRE-CREATION > > Diff: https://reviews.apache.org/r/18277/diff/ > > > Testing > ------- > > navigate to directory: test/selenium. (At the moment, all tests must be done > from this directory.) > # python cstests/smoketests/login_logout_test.py > > Output: > USLT-205731:selenium yichi.lu$ python cstests/smoketests/login_logout_test.py > ......... > ---------------------------------------------------------------------- > Ran 9 tests in 116.517s > > OK > > > Thanks, > > Yichi Lu > >
