Sebastien: Here is what I have (the username and email address are set before I submitted patch files):
USLT-205731:cloudstack yichi.lu$ git config --global user.name yichi.lu USLT-205731:cloudstack yichi.lu$ git config --global user.email yichi...@sungard.com USLT-205731:cloudstack yichi.lu$ vi ~/.gitconfig [user] name = yichi.lu email = yichi...@sungard.com and also from a patch file: >From 821cfc9fac26bf14db048ef437e649523af2c773 Mon Sep 17 00:00:00 2001 From: "yichi.lu" <yichi...@sungard.com> Date: Wed, 19 Feb 2014 12:00:54 -0600 Subject: [PATCH 1/3] initial check in Please advise what else I need to do. Thanks. Yichi On Sun, Mar 2, 2014 at 12:38 PM, Sebastien Goasguen <run...@gmail.com>wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18516/ > > Yichi, can you make sure to set your name and email in your .gitconfig with: > $ git config --global user.name "Your Name" > $ git config --global user.email y...@domain.com > > That way we can have proper ownership of the patch. > > If you can set those and re-submit the patch that would be best. > > thanks > > > - Sebastien Goasguen > > On February 26th, 2014, 3:27 p.m. UTC, Yichi Lu wrote: > Review request for cloudstack, Nitin Mehta, Parth Jagirdar, and > Sebastien Goasguen. > By Yichi Lu. > > *Updated Feb. 26, 2014, 3:27 p.m.* > *Repository: * cloudstack-git > Description > > add apache license headers to all files. add a new test: navigation_test.py. > > The tests were done against the 4.4.0 commit: > 5c8bd6657323c7ea27b06777fb9e1b87a0af5680 > > Testing > > USLT-205731:selenium yichi.lu$ python cstests/smoketests/login_logout_test.py > ......... > ---------------------------------------------------------------------- > Ran 9 tests in 219.643s > > OK > USLT-205731:selenium yichi.lu$ python cstests/smoketests/navigation_test.py > . > ---------------------------------------------------------------------- > Ran 1 test in 69.194s > > OK > > Diffs > > - test/selenium/browser/__init__.py (e69de29) > - test/selenium/browser/firefox.py (PRE-CREATION) > - test/selenium/browser/firefox.py (PRE-CREATION) > - test/selenium/common/Global_Locators.py (PRE-CREATION) > - test/selenium/common/Global_Locators.py (PRE-CREATION) > - test/selenium/common/__init__.py (e69de29) > - test/selenium/common/shared.py (PRE-CREATION) > - test/selenium/common/shared.py (PRE-CREATION) > - test/selenium/cspages/__init__.py (e69de29) > - test/selenium/cspages/dashboard/__init__.py (PRE-CREATION) > - test/selenium/cspages/dashboard/dashboardpage.py (PRE-CREATION) > - test/selenium/cspages/login/__init__.py (PRE-CREATION) > - test/selenium/cspages/login/loginpage.py (PRE-CREATION) > - test/selenium/cspages/login/loginpage.py (39e4295) > - test/selenium/cspages/loginpage.py (PRE-CREATION) > - test/selenium/cspages/loginpage.py (PRE-CREATION) > - test/selenium/cstests/__init__.py (e69de29) > - test/selenium/cstests/regressiontests/__init__.py (PRE-CREATION) > - test/selenium/cstests/smoketests/__init__.py (e69de29) > - test/selenium/cstests/smoketests/global_settings_test.py > (PRE-CREATION) > - test/selenium/cstests/smoketests/login_logout_test.py (PRE-CREATION) > - test/selenium/cstests/smoketests/login_logout_test.py (PRE-CREATION) > - test/selenium/cstests/smoketests/login_logout_test.py (PRE-CREATION) > - test/selenium/cstests/smoketests/navigation_test.py (PRE-CREATION) > - test/selenium/cstests/smoketests/smokecfg.py (PRE-CREATION) > - test/selenium/cstests/smoketests/smokecfg.py (PRE-CREATION) > > View Diff <https://reviews.apache.org/r/18516/diff/> >