> On Feb. 19, 2014, 9:27 p.m., Hugo Trippaers wrote: > > It looks like a lot of the license headers are wrong in this file. Please > > make sure they are complying to the license headers as they should be for > > CloudStack code. See the LICENSE.header file for examples, especially the > > copyright notice should not be there. > > > > Also isn't this a good time to feed the changes we need in the java > > bindings back to the xen-api-sdk project on github > > (https://github.com/xapi-project/xen-api-sdk)? It would be nice if we could > > just depend on that project instead of having to include a copy in our own > > source tree. > > David Nalley wrote: > This is not CloudStack code. This is a dependency that we've effectively > forked. We have no standing to change the license headers; it's not ours. > > Wholeheartedly agree - I'd far prefer we upstream our changes and stop > bundling this dependency. > > --David
That's right, we cannot change the Licence headers. As of now, with the released java bindings, there is some customization required to make it work with CloudStack (see the patch https://reviews.apache.org/r/17844/). If i am right, in the upcoming XenServer hotfix release, all the customization related to CloudStack code has been taken care of. So, in future, with that release, we can directly use the build instead of building it of our own. Please share your thoughts on this. Also, this patch has the support of vGPU functionality in XenServer which is a dependency for upcoming feature "GPU and vGPU support for CloudStack guestVms". --Sanjay - Sanjay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17843/#review34930 ----------------------------------------------------------- On Feb. 19, 2014, 7:31 p.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17843/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 7:31 p.m.) > > > Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das. > > > Bugs: CLOUDSTACK-6058 > https://issues.apache.org/jira/browse/CLOUDSTACK-6058 > > > Repository: cloudstack-git > > > Description > ------- > > Update the java bindings that are used in cloudstack with the latest one. > There are two parts for this change, 1st one is to replace the java bindings; > and second part is to add the customization's made in xenapi for Cloudstack. > > 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings. > 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for > CloudStack. > > > Diffs > ----- > > deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION > deps/XenServerJava/src/LICENSE.txt PRE-CREATION > deps/XenServerJava/src/Makefile PRE-CREATION > deps/XenServerJava/src/README.txt PRE-CREATION > deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d > deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac > deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 > deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 > deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 > deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 > deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 > deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 > deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 > deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 > deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 > deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 > deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 > deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 > deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a > deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 > deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 > deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 > deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef > deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 > deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a > deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 > deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 > deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e > deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 > deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 > deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 > deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 > deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f > deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f > deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c > deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 > deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 > deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d > deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 > deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 > deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b > deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa > deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 > deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd > deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION > deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 > deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 > deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 > deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c > deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 > deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 > deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 > deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e > deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 > deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee > > Diff: https://reviews.apache.org/r/17843/diff/ > > > Testing > ------- > > > Thanks, > > Sanjay Tripathi > >
