Hi Joris, This patch hasn't been applied yet, sorry for my second thought.
Could you comment on it? --Sheng On Thu, Feb 20, 2014 at 10:29 AM, Sheng Yang <sh...@yasker.org> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18310/ > > On February 20th, 2014, 6:17 p.m. UTC, *Sheng Yang* wrote: > > Looks good to me. > > Also I've confirmed that even with this option, the MAC would show in > dnsmasq.log, which is necessary for debug. > > Applied to MASTER. Thanks! > > On February 20th, 2014, 6:28 p.m. UTC, *Sheng Yang* wrote: > > One moment, on a second thought, even with current setup, dnsmasq won't hand > out IP to unknown host. So why this option is needed? > > And the log would show "DHCPDISCOVER(eth0) 02:01:3a:d9:00:02 no address > available" instead of "DHCPDISCOVER(eth0) 02:01:3a:d9:00:02 ignored" with the > option. > > Is there anything I missed? > > And the patch hasn't been applied yet... > > > - Sheng > > On February 20th, 2014, 2:01 p.m. UTC, Joris van Lieshout wrote: > Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng > Yang. > By Joris van Lieshout. > > *Updated Feb. 20, 2014, 2:01 p.m.* > *Repository: * cloudstack-git > Description > > When a ACS network is bridged to another non-ACS network (for instance using > a NSX Bridge) this will prevent dnsmasq from responding to requests from the > other network that have traversed the bridge. > > Testing > > We have been running this fix on our own version of the 4.2 and 3.0 SVM for a > couple months with success. > > Diffs > > - systemvm/patches/debian/config/etc/dnsmasq.conf.tmpl (07c5902) > > View Diff <https://reviews.apache.org/r/18310/diff/> >
