> On Feb. 19, 2014, 1:35 p.m., Wido den Hollander wrote: > > It seems good to me. Applies cleanly to master and builds just fine. > > > > Code-wise it's simple but effective, should allow us to support Gluster.
I just merged it into master and pushed. So gluster is in master right now! Niels, can I ask you to test it all again? Just to make sure the code all works like you intended. - Wido ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15932/#review34859 ----------------------------------------------------------- On Feb. 19, 2014, 8:24 a.m., Niels de Vos wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15932/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 8:24 a.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > The support for Gluster as Primary Storage is mostly based on the > implementation for NFS. Like NFS, libvirt can address a Gluster environment > through the 'netfs' pool-type. > > > Diffs > ----- > > api/src/com/cloud/storage/Storage.java ff83dfc > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > d63b643 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtStoragePoolDef.java > dbe5d4b > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtStoragePoolXMLParser.java > a6186f6 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java > ff75d61 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java > 8cdecd8 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java > a5f33eb > > plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java > b90d5fc > > Diff: https://reviews.apache.org/r/15932/diff/ > > > Testing > ------- > > See http://blog.nixpanic.net/2013/12/using-gluster-as-primary-storage-in.html > > > Thanks, > > Niels de Vos > >
