----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18114/#review34990 -----------------------------------------------------------
Ship it! Ship It! - Miguel Ferreira On Feb. 14, 2014, 2:48 p.m., Miguel Ferreira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18114/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2014, 2:48 p.m.) > > > Review request for cloudstack, daan Hoogland and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > Fix findbugs findings in cloudstack-service-console-proxy-rdpclient > > Findings: > - 32 int shifted by an amount not in range -31..31: > The shifts by 32 bits don't actually have any effect on the value > (as shown by the tests) > - possible null pointer dereference > - repeated conditional test > - field only ever set to null > All other uses of the field were to check if it was null, > which it was, so it was removed > > Other actions: > - Upgrade jUnit to version 4 > - Add PowerMock dependency > > > Diffs > ----- > > pom.xml 9dbd72b > services/console-proxy-rdp/rdpconsole/pom.xml 05585a1 > services/console-proxy-rdp/rdpconsole/src/main/java/common/Client.java > 688693b > > services/console-proxy-rdp/rdpconsole/src/main/java/streamer/ByteBuffer.java > 3a718ba > services/console-proxy-rdp/rdpconsole/src/test/java/common/ClientTest.java > PRE-CREATION > > services/console-proxy-rdp/rdpconsole/src/test/java/rdpclient/MockServerTest.java > 17bc4bd > > services/console-proxy-rdp/rdpconsole/src/test/java/streamer/ByteBufferParametricTest.java > PRE-CREATION > > services/console-proxy-rdp/rdpconsole/src/test/java/streamer/ByteBufferTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/18114/diff/ > > > Testing > ------- > > Added tests for code that changed and tested in Devcloud > > > Thanks, > > Miguel Ferreira > >
