> On Feb. 14, 2014, 9:08 a.m., Hugo Trippaers wrote: > > plugins/event-bus/inmemory/src/org/apache/cloudstack/mom/inmemory/InMemoryEventBus.java, > > line 63 > > <https://reviews.apache.org/r/18072/diff/1/?file=484234#file484234line63> > > > > Why recreate the map?
After explained how this method could be used, we agreed to remove the map recreation. > On Feb. 14, 2014, 9:08 a.m., Hugo Trippaers wrote: > > utils/src/com/cloud/utils/UuidUtils.java, line 27 > > <https://reviews.apache.org/r/18072/diff/1/?file=484236#file484236line27> > > > > UUID.fromString? And use this method in your other patch where you > > verify UUIDs? UUID.fromString() does not validate an UUID properly. I tried, for example, informing less digits in the UUID, where 12 were expected, and the UUID.fromstring() did not thrown the exception as expected. However, if you try UUID.fromString("aaa") it breaks, but if you try UUID.fromString("3dd4fa6e-2899-4429-b818-d34fe8df5") it doesn't (the last portion should have 12, instead of 9 digits). - Wilder ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18072/#review34466 ----------------------------------------------------------- On Feb. 13, 2014, 12:06 p.m., Wilder Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18072/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 12:06 p.m.) > > > Review request for cloudstack, daan Hoogland and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > Fixing 11 scary and 1 of concern issues found by FindBugs. Adding 13 unit > tests and also 1 validate method in the UuidUtils class. > > > Diffs > ----- > > > plugins/event-bus/inmemory/src/org/apache/cloudstack/mom/inmemory/InMemoryEventBus.java > 99d0a12 > > plugins/event-bus/inmemory/test/org/apache/cloudstack/mom/inmemory/InMemoryEventBusTest.java > PRE-CREATION > utils/src/com/cloud/utils/UuidUtils.java 7831bea > utils/test/com/cloud/utils/UuidUtilsTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/18072/diff/ > > > Testing > ------- > > Build successfully and added 13 unit tests > > > Thanks, > > Wilder Rodrigues > >
