-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18069/#review34469
-----------------------------------------------------------
Ship it!
commit 8c5886ee7fadcab11834f9e514cf05925f67fc33
Author: wrodrigues <wrodrig...@schubergphilis.com>
Date: Mon Feb 10 15:13:56 2014 +0100
fixing FindBugs scariest for replaceFirst() method call that does not
assign the return value
Signed-off-by: Hugo Trippaers <htrippa...@schubergphilis.com>
- Hugo Trippaers
On Feb. 13, 2014, 12:07 p.m., Wilder Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18069/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 12:07 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing FindBugs scariest for replaceFirst() method call that does not assign
> the return value
>
>
> Diffs
> -----
>
>
> plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
> 37861b4
>
> plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/provider/CloudStackPrimaryDataStoreProviderImpl.java
> 410416c
>
> Diff: https://reviews.apache.org/r/18069/diff/
>
>
> Testing
> -------
>
> Build ran successfully
>
>
> Thanks,
>
> Wilder Rodrigues
>
>
