----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17576/ -----------------------------------------------------------
(Updated Feb. 3, 2014, 10:48 p.m.) Review request for cloudstack, daan Hoogland and Hugo Trippaers. Changes ------- Some change in the Chain of Responsibility for the net dispatcher, which is based on list instead of wrappers and uses Spring. Also corresponding tests, headers... Repository: cloudstack-git Description ------- Detect & log unknown parameters for CS API and refactoring. There are plenty of changes for just refactoring purpose, but they are all related, most of them interdependant Diffs (updated) ----- api/src/org/apache/cloudstack/api/ApiConstants.java d500303 api/src/org/apache/cloudstack/api/BaseCmd.java 4229ec9 api/src/org/apache/cloudstack/api/BaseListCmd.java c1a4b4c api/src/org/apache/cloudstack/api/command/user/autoscale/CreateAutoScaleVmProfileCmd.java bee1b22 server/resources/META-INF/cloudstack/core/spring-server-core-misc-context.xml fd2f5fb server/src/com/cloud/api/ApiAsyncJobDispatcher.java 71ac616 server/src/com/cloud/api/ApiDispatcher.java 55ef53a server/src/com/cloud/api/ApiServer.java d715db6 server/src/com/cloud/api/ApiServlet.java 46f7eba server/src/com/cloud/api/ParameterHandler.java PRE-CREATION server/src/com/cloud/api/dispatch/CommandCreationWorker.java PRE-CREATION server/src/com/cloud/api/dispatch/DispatchChain.java PRE-CREATION server/src/com/cloud/api/dispatch/DispatchChainFactory.java PRE-CREATION server/src/com/cloud/api/dispatch/DispatchWorker.java PRE-CREATION server/src/com/cloud/api/dispatch/ParamGenericValidationWorker.java PRE-CREATION server/src/com/cloud/api/dispatch/ParamProcessWorker.java PRE-CREATION server/src/com/cloud/api/dispatch/ParamSemanticValidationWorker.java PRE-CREATION server/src/com/cloud/network/as/AutoScaleManagerImpl.java a2cc32e server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java bf2516a server/src/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java 3159059 server/test/com/cloud/api/ApiDispatcherTest.java 7314a57 server/test/com/cloud/api/dispatch/CommandCreationWorkerTest.java PRE-CREATION server/test/com/cloud/api/dispatch/DispatchChainFactoryTest.java PRE-CREATION server/test/com/cloud/api/dispatch/ParamGenericValidationWorkerTest.java PRE-CREATION server/test/com/cloud/api/dispatch/ParamProcessWorkerTest.java PRE-CREATION server/test/com/cloud/api/dispatch/ParamSemanticValidationWorkerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/17576/diff/ Testing ------- mvn full build and manual test of functionalities Thanks, Antonio Fornie
