-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/#review33400
-----------------------------------------------------------



client/WEB-INF/web.xml
<https://reviews.apache.org/r/12228/#comment62858>

    can you use tabs instead of spaces (and while you are at it remove trailing 
spaces from this file)?



client/pom.xml
<https://reviews.apache.org/r/12228/#comment62859>

    please remove tab



server/src/com/cloud/servlet/StaticResourceServlet.java
<https://reviews.apache.org/r/12228/#comment62857>

    please add a license header



server/test/com/cloud/servlet/StaticResourceServletTest.java
<https://reviews.apache.org/r/12228/#comment62856>

    please add a license header


- daan Hoogland


On Feb. 2, 2014, 5:04 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12228/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2014, 5:04 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna 
> Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CloudStack at first use downloads some 3.5 MB of css and javascript to the 
> client. With a weak internet connection, this might take a long time. With 
> gzip compression content can be compressed to 850 KB.
> 
> This version of the patch uses a custom plugin to compress static resources, 
> so that no dynamic compression is needed at runtime. When the static resource 
> servlet notices that there is gzipped version of the resource and the client 
> accepts gzipped content, then it is going to send the gziped version, while 
> still respects http caching.
> 
> 
> Diffs
> -----
> 
>   client/WEB-INF/web.xml e5c05d3 
>   client/pom.xml 119c96e 
>   server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
>   server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12228/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>

Reply via email to