----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17638/#review33396 -----------------------------------------------------------
pom.xml <https://reviews.apache.org/r/17638/#comment62852> Hardcoded repo url?? Please no :) - David Nalley On Feb. 2, 2014, 7:47 a.m., Antonio Fornie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17638/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2014, 7:47 a.m.) > > > Review request for cloudstack, daan Hoogland and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > Rest client moved to utils in a generic way so it can be reused (from > opendaylight, for example). Incremented integration tests. Also include > cobertura and it-cobertura. Nvp extended with a few methods missing. > > > Diffs > ----- > > plugins/network-elements/nicira-nvp/pom.xml a4b4c49 > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AccessConfiguration.java > 74fe19d > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/Acl.java > 3a9b387 > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/BaseNiciraEntity.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/BaseNiciraNamedEntity.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalRouter.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalRouterConfig.java > 5c99e15 > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalRouterPort.java > ed1b8da > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitch.java > c2d75a7 > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitchPort.java > da58c78 > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java > 92c23eb > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SingleDefaultRouteImplicitRoutingConfig.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SingleDefaultRouteImplictRoutingConfig.java > d386e70 > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/VifAttachment.java > 7b37ac1 > > plugins/network-elements/nicira-nvp/src/com/cloud/network/resource/NiciraNvpResource.java > 8c99a81 > > plugins/network-elements/nicira-nvp/test/com/cloud/network/element/NiciraNvpElementTest.java > 436c86c > > plugins/network-elements/nicira-nvp/test/com/cloud/network/guru/NiciraNvpGuestNetworkGuruTest.java > 3e303b8 > > plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NatRuleTest.java > 1a63527 > > plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiIT.java > c541d87 > > plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiTest.java > 2e4cfaf > > plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraTagTest.java > 7512803 > > plugins/network-elements/nicira-nvp/test/com/cloud/network/resource/NiciraNvpResourceTest.java > ad01218 > pom.xml 85cfb89 > utils/pom.xml f63d7c4 > utils/src/com/cloud/utils/rest/BasicEncodedRESTValidationStrategy.java > PRE-CREATION > utils/src/com/cloud/utils/rest/CloudstackRESTException.java PRE-CREATION > utils/src/com/cloud/utils/rest/RESTServiceConnector.java PRE-CREATION > utils/src/com/cloud/utils/rest/RESTValidationStrategy.java PRE-CREATION > utils/test/com/cloud/utils/rest/RESTServiceConnectorTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/17638/diff/ > > > Testing > ------- > > mvn full build plus unit and integration tests > > > Thanks, > > Antonio Fornie > >
