I think the issue Hugo fixed should trigger another RC. But still, we need to test as much as we can for current RC now. It would make the release work easier.
--Sheng On Thu, Jan 23, 2014 at 11:51 AM, Animesh Chaturvedi < animesh.chaturv...@citrix.com> wrote: > Hugo > > Thanks for running find bugs and finding the issues let's wait for some > more comments on the issues called out. Copying some folks for input. It's > always good to call out the issues but I wish we had run find bugs sooner. > > Thanks > Animesh > > -----Original Message----- > From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers > Sent: Thursday, January 23, 2014 12:21 AM > To: dev > Subject: Re: [VOTE] Apache CloudStack 4.3.0 (first round) > > Thanks Animesh, > > Great to see the first RC for 4.3. > > I've been running some findbugs analysis on master and found several > issues that also seem to be present in the 4.3 branch. I've made two commit > on master that fixed some issues that i spotted > (c2da2803476d55e814ec0d849482bd07c4f9f8f1 and > d19157fbb169eec029d1efee9ddd06e6b6aad9a4). Both fix an issue where an > object is compared by using == instead of equals. I'm doubting if this is > worth to -1 the current RC as i can't oversee the impact of these bugs and > looking for opinions. > > Cheers, > > Hugo > > > > > > > On 23 jan. 2014, at 06:54, Animesh Chaturvedi < > animesh.chaturv...@citrix.com> wrote: > > > > > > > > > Hi All, > > > > > > > > I've created a 4.3.0 release, with the following artifacts up for a > > > > vote: > > > > > > > > Git Branch and Commit SH: > > > > > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.3 > > Commit: 43d485c92d5919085cacb1cd0c7e78503ab9788a > > > > > > > > List of changes: > > > > > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=CHANGES;hb=4.3 > > > > > > > > Source release (checksums and signatures are available at the same > > > > location): > > > > https://dist.apache.org/repos/dist/dev/cloudstack/4.3.0/ > > > > > > > > PGP release keys (signed using 94BE0D7C): > > > > https://dist.apache.org/repos/dist/release/cloudstack/KEYS > > > > > > > > Testing instructions are here: > > > > > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+test+procedure > > > > > > > > Vote will be open for 72 hours. > > > > > > > > For sanity in tallying the vote, can PMC members please be sure to > indicate "(binding)" with their vote? > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove (and reason why) > > > > > > > >
