----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16780/ -----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2031 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-2031 Repository: cloudstack-git Description ------- support for number of ips per nic limit needs to be added for the multiple ip address per nic Diffs ----- api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java b5e2239 engine/schema/src/com/cloud/vm/dao/NicSecondaryIpDao.java da96df4 engine/schema/src/com/cloud/vm/dao/NicSecondaryIpDaoImpl.java 3befaf7 server/src/com/cloud/configuration/Config.java d2713c0 server/src/com/cloud/network/NetworkServiceImpl.java 11313d5 setup/db/db/schema-421to430.sql c1f9780 Diff: https://reviews.apache.org/r/16780/diff/ Testing ------- Tested the same by changing default value from 256 to 2. Also tested the new acquire of ip if number if IPs are less than in that nic than the max limit Thanks, Damodar Reddy Talakanti