----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16361/#review31417 -----------------------------------------------------------
One more check is needed: don't let to add vm to VPC network if its already a part of another VPC network. - Alena Prokharchyk On Dec. 19, 2013, 5:25 a.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16361/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2013, 5:25 a.m.) > > > Review request for cloudstack and Alena Prokharchyk. > > > Bugs: CLOUDSTACK-5535 > https://issues.apache.org/jira/browse/CLOUDSTACK-5535 > > > Repository: cloudstack-git > > > Description > ------- > > addNetworkToVM allows adding any network to VM. > Ideally a VM running in isolated Guest Network should not be able to add a > VPC tier. > A VM running in VPC tier should not be allowed to add another tier > A VM running in VPC tier should not be allowed to add another isolated guest > network > > > Diffs > ----- > > server/src/com/cloud/vm/UserVmManagerImpl.java 3ad49d8 > > Diff: https://reviews.apache.org/r/16361/diff/ > > > Testing > ------- > > VM having a nic in isolated guest network cannot add a VPC tier. > VM having a nic in one VPC tier cannot add another VPC tier. > VM having a nic in a VPC tier cannot add a isolated guest network. > > > Thanks, > > Saksham Srivastava > >
