----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16152/#review30190 -----------------------------------------------------------
Ship it! Ship It! - Abhinandan Prateek On Dec. 10, 2013, 8:15 a.m., Rajani Karuturi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16152/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2013, 8:15 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Ian Duffy. > > > Bugs: CLOUDSTACK-5375 > https://issues.apache.org/jira/browse/CLOUDSTACK-5375 > > > Repository: cloudstack-git > > > Description > ------- > > Added support for 4.2 ldap apis > in the old api, queryfilter and ssl are used which doesnt exist in the new > api. they are ignored. > > > Diffs > ----- > > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPConfigCmd.java > PRE-CREATION > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPRemoveCmd.java > PRE-CREATION > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LDAPConfigResponse.java > PRE-CREATION > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LDAPRemoveResponse.java > PRE-CREATION > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java > f41bd3a > > Diff: https://reviews.apache.org/r/16152/diff/ > > > Testing > ------- > > manually tested. > > > Thanks, > > Rajani Karuturi > >