----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15566/#review30011 -----------------------------------------------------------
Ship it! f194adb2ded586516f98e045bb318ca1af0730e5 - daan Hoogland On Dec. 9, 2013, 1:32 p.m., Yichi Lu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15566/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2013, 1:32 p.m.) > > > Review request for cloudstack and daan Hoogland. > > > Bugs: CLOUDSTACK-4969 > https://issues.apache.org/jira/browse/CLOUDSTACK-4969 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-4969 > In server/src/com/cloud/resource/ResourceManagerImpl.java near line 1264, > there is a line: if (guestOSCategory != null && > !GuestOSCategoryVO.CATEGORY_NONE.equalsIgnoreCase(guestOSCategory.getName())). > But since GuestOSCategoryVO.CATEGORY_NONE = 'None' and > guestOSCategory.getName() = 'None', this would cause OS category of 'None' to > not be selected. Removing it does the job. > Notice the OS category of 'None' at the top of the dropdown list does not > have a valid guestOSCategoryid (and would be null). > > > Diffs > ----- > > server/src/com/cloud/resource/ResourceManagerImpl.java 7579b8f > > Diff: https://reviews.apache.org/r/15566/diff/ > > > Testing > ------- > > Tested against cloudstack GUI. Was able to change OS category to 'None', the > bottom one, and change it back to other OS categories. Selecting the top > 'None' would have no effect. > > > Thanks, > > Yichi Lu > >
