-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16042/
-----------------------------------------------------------

(Updated Dec. 6, 2013, 8:17 p.m.)


Review request for cloudstack.


Changes
-------

Made the fix only affect 'ActionEventUtils.java' because it doesn't seem to be 
good for 'CallContext' class to know about the events. All it does is just to 
store and retrieve data without knowing what the data is about.


Repository: cloudstack-git


Description
-------

Bug fix for CLOUDSTACK-3190 (action events message published on 'event bus' 
should have the UUID of the entity for which event generated and event type).


Diffs (updated)
-----

  server/src/com/cloud/event/ActionEventUtils.java eba6874 

Diff: https://reviews.apache.org/r/16042/diff/


Testing
-------

Confirmed that 'entity' & 'entityuuid' are included in the messages.

[x] 
'management-server.ActionEvent.USER-CREATE.User.*':'{"eventDateTime":"2013-12-05
 12:45:10 -0600","status":"Completed","description":"Successfully completed 
creating User. UserName: test2, FirstName :a, LastName: 
a","event":"USER.CREATE","entityuuid":"67888f40-80f3-4ec0-9a45-e1f729cf7b36","entity":"com.cloud.user.User","account":"32907226-5dd5-11e3-a6af-d073d0b82aa6","user":"3295ad2c-5dd5-11e3-a6af-d073d0b82aa6"}'

 [x] 
'management-server.ActionEvent.USER-DELETE.User.*':'{"eventDateTime":"2013-12-05
 12:45:38 -0600","status":"Completed","description":"Successfully completed 
deleting User. UserId: 
5","event":"USER.DELETE","entityuuid":"67888f40-80f3-4ec0-9a45-e1f729cf7b36","entity":"com.cloud.user.User","account":"32907226-5dd5-11e3-a6af-d073d0b82aa6","user":"3295ad2c-5dd5-11e3-a6af-d073d0b82aa6"}'


Thanks,

Alex Ough

Reply via email to