----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15962/#review29704 -----------------------------------------------------------
Commit 171c7e950b22a4aa6cd6e8b9051436794bb41373 in branch refs/heads/4.3 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=171c7e9 ] CLOUDSTACK-5346: Fixed shared network cleanup issue - ASF Subversion and Git Services On Dec. 3, 2013, 2:15 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15962/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2013, 2:15 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5346 > https://issues.apache.org/jira/browse/CLOUDSTACK-5346 > > > Repository: cloudstack-git > > > Description > ------- > > component.test_project_resources.TestNetwork.test_03_network_create failed > due to "Exception during cleanup: Failed to delete network" > > The test case failed to delete the shared network because it has 1 VM in it. > > Resolution: > Deleted the VM and waited for expunge interval before proceeding to network > cleanup. > > Other changes: > Code cleanup and changes related to imports, getting free vlan and setting > the startip,endip,netmask of shared network using random subnet number to > avoid conflict. > > > Diffs > ----- > > test/integration/component/test_project_resources.py 9b9b2e6 > > Diff: https://reviews.apache.org/r/15962/diff/ > > > Testing > ------- > > Tested locally on XenServer setup. > > Log: > test_03_network_create (test_project_resources_fixed.TestNetwork) > Test create network in project ... ok > test_01_service_offerings (test_project_resources_fixed.TestOfferings) > Test service offerings in a project ... skipped 'skip' > test_02_project_disk_offerings (test_project_resources_fixed.TestOfferings) > Test project disk offerings ... skipped 'skip' > test_07_associate_public_ip (test_project_resources_fixed.TestPublicIpAddress) > Test associate public IP within the project ... skipped 'skip' > test_08_security_group (test_project_resources_fixed.TestSecurityGroup) > Test security groups in project ... skipped 'skip' > test_06_create_snapshots_in_project > (test_project_resources_fixed.TestSnapshots) > Test create snapshots in project ... skipped 'skip' > test_04_public_template_use_in_project > (test_project_resources_fixed.TestTemplates) > Test Templates creation in projects ... skipped 'skip' > test_05_use_private_template_in_project > (test_project_resources_fixed.TestTemplates) > Test use of private template in a project ... skipped 'skip' > > ---------------------------------------------------------------------- > Ran 8 tests in 479.325s > > OK (skipped=7) > > > Thanks, > > Gaurav Aradhye > >
