> On Nov. 27, 2013, 12:56 p.m., daan Hoogland wrote: > > server/src/com/cloud/vm/UserVmManagerImpl.java, line 2724 > > <https://reviews.apache.org/r/15875/diff/1/?file=391529#file391529line2724> > > > > Is there a guarantee that the parameter is castable to Long?
sorry for the delay in reply, was working on another patch. This will throw a number format exception if the rootdkisk size value is not a number. fixed this by using a parser in NumberUtils. - bharat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15875/#review29485 ----------------------------------------------------------- On Dec. 3, 2013, 6:20 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15875/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2013, 6:20 a.m.) > > > Review request for cloudstack, Jayapal Reddy and Koushik Das. > > > Bugs: CLOUDSTACK-5160 > https://issues.apache.org/jira/browse/CLOUDSTACK-5160 > > > Repository: cloudstack-git > > > Description > ------- > > use a map to specify the custom parameters in the deployvm api Instead of one > parameter for each. > > https://issues.apache.org/jira/browse/CLOUDSTACK-5160 > > > Diffs > ----- > > api/src/com/cloud/vm/UserVmService.java ac14da7 > api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java f075082 > server/src/com/cloud/vm/UserVmManagerImpl.java d3dd356 > > Diff: https://reviews.apache.org/r/15875/diff/ > > > Testing > ------- > > Tested on master. > > > Thanks, > > bharat kumar > >
