> On Nov. 27, 2013, 10:28 a.m., daan Hoogland wrote: > > framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java, > > line 171 > > <https://reviews.apache.org/r/15667/diff/2/?file=391484#file391484line171> > > > > isn't this one superfluent? (Does coverity force you to do this?)
Yes... coverity forces a bit those "Resource leaks" errors - Wilder ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15667/#review29481 ----------------------------------------------------------- On Nov. 27, 2013, 9:47 a.m., Wilder Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15667/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 9:47 a.m.) > > > Review request for cloudstack and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > Fixing resource leak on Coverity issues CID_1116744, CID_1116718 and > CID_1116682. > > The resource leak problems were mostly related to InpuStreams instantiated > and not closed after used. > > > Diffs > ----- > > > framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java > 177ae09 > server/src/com/cloud/api/doc/ApiXmlDocWriter.java a91530b > server/src/com/cloud/server/ConfigurationServerImpl.java cfc95ca > > Diff: https://reviews.apache.org/r/15667/diff/ > > > Testing > ------- > > A full build was executed on top of the branch created for these changes. > After committed and patched, the a brand new branch was created from Master > and patched with this patch. Everything worked fine. > > No new feature was added. > > > Thanks, > > Wilder Rodrigues > >
