----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15513/ -----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5166 https://issues.apache.org/jira/browse/CLOUDSTACK-5166 Repository: cloudstack-git Description ------- Assert was wrong in both test cases. When egress rule is authorized for security group with cidr 0.0.0.0/0, ping to outside world from vm should be successful. Corrected the assert and also removed the hard coded management server ip address. Diffs ----- test/integration/component/test_egress_rules.py 34995ff Diff: https://reviews.apache.org/r/15513/diff/ Testing ------- Tested locally on XenServer Basic Zone setup. Log: test_deployVM_InDefaultSecurityGroup (test_egress_rules.TestDefaultSecurityGroupEgress) Test deploy VM in default security group with no egress rules ... skipped 'Skip' test_invalid_account_authroize (test_egress_rules.TestInvalidAccountAuthroize) Test invalid account authroize ... skipped 'Skip' test_invalid_parameters (test_egress_rules.TestInvalidParametersForEgress) Test invalid parameters for egress rules ... skipped 'Skip' test_multiple_account_egress_rule_positive (test_egress_rules.TestMultipleAccountsEgressRule) Test multiple account egress rules positive case ... skipped 'Skip' test_multiple_account_egress_rule_negative (test_egress_rules.TestMultipleAccountsEgressRuleNeg) Test multiple account egress rules negative case ... skipped 'Skip' test_revoke_egress_rule (test_egress_rules.TestRevokeEgressRule) Test revoke security group egress rule ... skipped 'Skip' test_start_stop_vm_egress (test_egress_rules.TestStartStopVMWithEgressRule) Test stop start Vm with egress rules ... skipped 'Skip' ---------------------------------------------------------------------- Ran 10 tests in 210.128s OK (skipped=8) Thanks, Ashutosh Kelkar