----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15475/ -----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5154 https://issues.apache.org/jira/browse/CLOUDSTACK-5154 Repository: cloudstack-git Description ------- Fixed component.test_project_limits.TestResourceLimitsProject.test_05_snapshots_per_project Test was failing in creating snapshot because the volume from which the snapshot is getting created is incorrect. It is obtained by listing the volumes belonging to the project, which sometimes can list volumes belonging to expunging vms. Passed virtualmachineid to the list_volumes method so as to get the correct volume. Diffs ----- test/integration/component/test_project_limits.py 04e6922 Diff: https://reviews.apache.org/r/15475/diff/ Testing ------- Tested locally on XenServer Basic Zone setup: Result log: test_maxAccountNetworks (test_project_limits.TestMaxProjectNetworks) Test Limit number of guest account specific networks ... skipped 'skip' test_01_project_limits (test_project_limits.TestProjectLimits) Test project limits for domain admin ... skipped 'skip' test_02_project_limits_normal_user (test_project_limits.TestProjectLimits) Test project limits for normal user ... skipped 'skip' test_03_vm_per_project (test_project_limits.TestResourceLimitsProject) Test VM limit per project ... skipped 'skip' test_04_publicip_per_project (test_project_limits.TestResourceLimitsProject) Test Public IP limit per project ... skipped 'skip' test_05_snapshots_per_project (test_project_limits.TestResourceLimitsProject) Test Snapshot limit per project ... ok test_06_volumes_per_project (test_project_limits.TestResourceLimitsProject) Test Volumes limit per project ... skipped 'skip' test_07_templates_per_project (test_project_limits.TestResourceLimitsProject) Test Templates limit per project ... skipped 'skip' ---------------------------------------------------------------------- Ran 8 tests in 156.657s OK (skipped=7) Client Log: 2013-11-12 23:25:44,629 - DEBUG - test_05_snapshots_per_project (test_project_limits.TestResourceLimitsProject) - Updating snapshot resource limits for project: 540a482c-8add-4b08-9c67-1d551280eb56 2013-11-12 23:25:44,651 - DEBUG - test_05_snapshots_per_project (test_project_limits.TestResourceLimitsProject) - Deploying VM in project: 540a482c-8add-4b08- 9c67-1d551280eb56 2013-11-12 23:25:59,970 - DEBUG - test_05_snapshots_per_project (test_project_limits.TestResourceLimitsProject) - 6e611bc3-ebf3-4b41-9af9-3411b8093ea5 2013-11-12 23:25:59,989 - DEBUG - test_05_snapshots_per_project (test_project_limits.TestResourceLimitsProject) - [{domain : u'Domain-MW39F9', domainid : u'97742857-7330-4c22-994c-48471d5e26bb', projectid : u'540a482c-8add-4b08-9c67-1d551280eb56', zoneid : u'2c42d5dc-7377-4385-b2fa-dd6fd837380f', vmname : u'6e611bc3-ebf3-4b41-9af9-3411b8093ea5', id : u'bc2720d9-ece4-4ce0-afc3-8243f28ccf86', size : 21474836480, storage : u'primary0clus0', displayvolume : False, destroyed : False, state : u'Ready', serviceofferingdisplaytext : u'Tiny Instance', vmdisplayname : u'TestVM', type : u'ROOT', serviceofferingid : u'aac1cc50- 0d2e-4d47-ae0b-1e8f4f9777e7', zonename : u'test0', tags : [], isextractable : True, name : u'ROOT-259', virtualmachineid : u'6e611bc3-ebf3-4b41-9af9- 3411b8093ea5', storagetype : u'shared', hypervisor : u'XenServer', created : u'2013-11-13T02:59:13-0800', vmstate : u'Running', project : u'Project-VDCYWI', deviceid : 0, serviceofferingname : u'Tiny Instance'}] 2013-11-12 23:25:59,989 - DEBUG - test_05_snapshots_per_project (test_project_limits.TestResourceLimitsProject) - Creating snapshot from volume: bc2720d9-ece4- 4ce0-afc3-8243f28ccf86 Thanks, Ashutosh Kelkar