-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15391/
-----------------------------------------------------------

Review request for cloudstack and Syed Ahmed.


Repository: cloudstack-git


Description
-------

Tests:
    - all tests are @Test rather than having one test to call them, so they can 
be run one by one
    - tests that expect exception from a method fail if there is none
    - no longer extends TestCase so that the original method names could be 
kept as test
    
    Implementation:
    - include root cause in exceptions when possible - helps at troubleshuting
    - close readers


Diffs
-----

  server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 53dae50 
  server/test/org/apache/cloudstack/network/lb/CertServiceTest.java e47fc01 

Diff: https://reviews.apache.org/r/15391/diff/


Testing
-------


Thanks,

Laszlo Hornyak

Reply via email to