-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15264/#review28264
-----------------------------------------------------------
Ship it!
commit 56070c644b026003b155bdb69b356a286e122a46
Author: wilderrodrigues <wrodrig...@schubergphilis.com>
Date: Wed Nov 6 14:18:31 2013 +0100
Fix for 1125389 RV: Bad use of return value - make sure the replace call is
done after replaceAll and the correct value is returned
Signed-off-by: Hugo Trippaers <htrippa...@schubergphilis.com>
- Hugo Trippaers
On Nov. 6, 2013, 2:08 p.m., Wilder Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15264/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 2:08 p.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Bugs: 1125389
> https://issues.apache.org/jira/browse/1125389
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> In
> org.?apache.?cloudstack.?network.?contrail.?management.?ContrailManagerImpl.?getPhysicalNetworkName(com.?cloud.?network.?dao.?PhysicalNetworkVO):
> The return value of this method should be checked. (From FindBugs™
> description) (CWE-440)
>
>
> Diffs
> -----
>
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java
> ae9bba9
>
> Diff: https://reviews.apache.org/r/15264/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Wilder Rodrigues
>
>
