----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15012/#review27695 -----------------------------------------------------------
Ship it! Toshiaki, please commit. - Marcus Sorensen On Oct. 29, 2013, 5 a.m., Yoshikazu Nojima wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15012/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2013, 5 a.m.) > > > Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano. > > > Repository: cloudstack-git > > > Description > ------- > > Linux vxlan interface doesn't accept VNI:16777215. > https://github.com/torvalds/linux/blob/master/drivers/net/vxlan.c#L2140 > > As far as I read internet draft ( > http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-05 ), > 16777215 is a valid VNI, but it cannot be used in Linux now. > > This patch decrements MAX_VXLAN_VNI to 16777214. > > > Diffs > ----- > > server/src/com/cloud/network/NetworkServiceImpl.java 61c070a > > Diff: https://reviews.apache.org/r/15012/diff/ > > > Testing > ------- > > I confirmed VNI validation works by specifying 16777215-16777215 to id range > via add zone wizard. > > > Thanks, > > Yoshikazu Nojima > >
