----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14823/ -----------------------------------------------------------
Review request for cloudstack, Chris Suich and edison su. Repository: cloudstack-git Description ------- I specifically ran into a problem in the spring modularization branch with StrategyPriority.sortStrategies(). The lists of strategies are unmodifiable collections so Collection.sort() can not be used. I went to do a quick fix for this but then decided to try remove the duplicated logic in each code that needs a SnapshotStrategy or DataMotionStrategy and then ended up refactoring quite a bit. Diffs ----- engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataMotionStrategy.java 950f9e2 engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotStrategy.java e4cecb6 engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/StorageStrategyFactory.java PRE-CREATION engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriority.java 81034b1 engine/api/test/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriorityTest.java 3d75279 engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java 5f5f01e engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/DataMotionServiceImpl.java 2d31320 engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java 6a874d6 engine/storage/src/org/apache/cloudstack/storage/helper/StorageStrategyFactoryImpl.java PRE-CREATION engine/storage/test/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriorityTest.java PRE-CREATION plugins/hypervisors/xen/src/org/apache/cloudstack/storage/motion/XenServerStorageMotionStrategy.java 8578a9a server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java dade983 Diff: https://reviews.apache.org/r/14823/diff/ Testing ------- Thanks, Darren Shepherd
