> On Oct. 21, 2013, 7:19 a.m., SrikanteswaraRao Talluri wrote: > > test/integration/component/maint/test_multiple_ip_ranges.py, line 150 > > <https://reviews.apache.org/r/14737/diff/1/?file=366277#file366277line150> > > > > Skip the test if the zone.networktype is not basic. > > > > if cls.zone.networktype == 'Basic': > > cls.new_vlan = PublicIpRange.create(cls.api_client, > > cls.services["vlan_ip_range"]) > > else: > > self.skipTest("This test can be run only on basic zone")
Oh this is in setupclass, you can use this if cls.zone.networktype == 'Basic': cls.new_vlan = PublicIpRange.create(cls.api_client, cls.services["vlan_ip_range"]) else: raise unittest.SkipTest("This can be run only on basic zone only") - SrikanteswaraRao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14737/#review27231 ----------------------------------------------------------- On Oct. 18, 2013, 9:27 a.m., sanjeev n wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14737/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2013, 9:27 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Repository: cloudstack-git > > > Description > ------- > > Added following code in the existing test > 1.Moved vm deployment code to setUp method and vm destroy code to tearDown > method > 2.Added test to verify ip alias removal after destroying last vm in the cidr > 3.Added tests to verify ip alias verification on VR after reboot and > stop/start VR > > > Diffs > ----- > > test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e > > Diff: https://reviews.apache.org/r/14737/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > sanjeev n > >