----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14147/#review27177 -----------------------------------------------------------
Please update the diff to remove the change made to base.py as it has already been checked in. Otherwise it looks good to me. Good test case coverage. - Likitha Shetty On Sept. 16, 2013, 11:26 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14147/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2013, 11:26 a.m.) > > > Review request for cloudstack, Likitha Shetty, sailaja mada, and Prasanna > Santhanam. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2232 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-2232 > > > Repository: cloudstack-git > > > Description > ------- > > marvin tests for Persistent networks without running a VM > > > Diffs > ----- > > test/integration/component/test_persistent_networks.py PRE-CREATION > tools/marvin/marvin/integration/lib/base.py 9e46065 > > Diff: https://reviews.apache.org/r/14147/diff/ > > > Testing > ------- > > ran successfully on my local advanced zone setup > > > Thanks, > > Anshul Gangwar > >