On Oct 16, 2013, at 9:08 PM, Darren Shepherd <darren.s.sheph...@gmail.com> wrote:
> How do these merge emails work? Do I just wait and certain amount of time > and if nobody says no I just do it? I've tested the branch as much as I'd > like, so just waiting for input. > I think there is a 72 hours window, but we might want to wait one week to get this one merged ? > Darren > >> On Oct 16, 2013, at 9:59 AM, Darren Shepherd <darren.s.sheph...@gmail.com> >> wrote: >> >> I need as many people as possible to review this branch. I'm still >> testing it out, but I wanted to get as many eyes on it as possible. >> This is a huge cross cutting change. This branch is the changes to >> use a new Transaction API that will be consistent Spring TX's style so >> that we can eventually move to it. You can get a bit more context >> from >> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Database+Transactions >> >> Having spent so much time looking at the transaction management in >> ACS, I'm well convinced we need to adopt Spring TX as soon as we can. >> I've found just too many bugs. It will be a painful transitiion, as >> you can see from this branch. It will also be very tricky, but I'll >> figure it out. >> >> If you are reviewing this branch, use a diff tool that ignores >> whitespace. Also if you don't know about "git difftool -d", you >> should use that. Just know, its was 10x more tedious and painful for >> me to make this change then it is for you to review it :) >> >> Darren
