This is interesting... Got couple of questions, if I may,
What is the reason for the cluster limitation? Does it mean Autoscaling
conditions are evaluated for the LB within the cluster only?
Looks like the new counters to be used for non-netscaler configurations are
cpu, memory.
> -----Original Message-----
> From: tuna [mailto:nore...@reviews.apache.org] On Behalf Of tuna
> Sent: Tuesday, October 15, 2013 4:50 PM
> To: Sebastien Goasguen
> Cc: tuna; cloudstack
> Subject: Re: Review Request 14628: AutoScaling without NetScaler
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14628/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2013, 11:20 a.m.)
>
>
> Review request for cloudstack and Sebastien Goasguen.
>
>
> Changes
> -------
>
> fix issues
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> I made a patch to add autoscale feature without Netscaler.
>
> Requirement:
> - Xenserver or XCP
> - Template with pre-installed PVdriver
> - don't use SNMP or NetScaler counters when configuring AutoScale
> - AutoScale acts within a Cluster
>
> All configuration parameters (durations, interval, destroy_vm_grace_period,
> quiet_time) are kept as normal.
>
>
> Diffs (updated)
> -----
>
> api/src/com/cloud/network/as/AutoScaleCounter.java
> ca7b65a39d4c063029293da1e1eb6832c11425a7
> api/src/com/cloud/network/as/AutoScalePolicy.java
> 7f94f355921bba1ce149ff44f60a5c0e9a5cde28
> api/src/com/cloud/network/as/AutoScaleVmGroup.java
> faa166d2baeb9e49cc064cf9da802a8e56219e00
> api/src/com/cloud/network/as/Counter.java
> 207ec57b5920ad0a28088f37b1c3d5bb59c916fc
> client/tomcatconf/applicationContext.xml.in
> 6dda5c707afddd1c20c97cb9a553590730682db3
> core/src/com/cloud/agent/api/PerformanceMonitorAnswer.java PRE-
> CREATION
> core/src/com/cloud/agent/api/PerformanceMonitorCommand.java PRE-
> CREATION
> engine/schema/src/com/cloud/network/as/AutoScalePolicyVO.java
> f8fbcb483f52ddba3528e2f10644a7322716ce71
> engine/schema/src/com/cloud/network/as/AutoScaleVmGroupVO.java
> d1d85f9e2932f5ce5347e0b0be25af31a5f07066
> engine/schema/src/com/cloud/network/as/AutoScaleVmGroupVmMapVO.java
> PRE-CREATION
> engine/schema/src/com/cloud/network/as/CounterVO.java
> b7b03f716b09c8600f8587b3c47124e228d643bb
>
> engine/schema/src/com/cloud/network/as/dao/AutoScalePolicyConditionMap
> Dao.java 30251984807f9556e8856b1a987ea01ca914a26b
>
> engine/schema/src/com/cloud/network/as/dao/AutoScalePolicyConditionMap
> DaoImpl.java 00fee3db6c7e6ee6ab7493d38060267b78fd4ebb
>
> engine/schema/src/com/cloud/network/as/dao/AutoScaleVmGroupVmMapDao
> .java PRE-CREATION
>
> engine/schema/src/com/cloud/network/as/dao/AutoScaleVmGroupVmMapDao
> Impl.java PRE-CREATION
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResource
> Base.java 92fbab28bd24a115d6e933d58ab94390e357c9f7
> scripts/vm/hypervisor/xenserver/perfmon.py PRE-CREATION
> scripts/vm/hypervisor/xenserver/vmopspremium
> 38ec2e8c1d8d4dfc9bf60df94bf9412d877d128e
> server/src/com/cloud/network/as/AutoScaleManager.java
> 5b84b30d74415b7d3c278b6c2dd78fb39bea3668
> server/src/com/cloud/network/as/AutoScaleManagerImpl.java
> 859211bd572a8a0d56ae6fd154788944db58fb24
> server/src/com/cloud/network/element/VirtualRouterElement.java
> 0cd3bcf6db05eddb5f6dfdd3e747d509d84c1164
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java
> c685ee3e40ba1f1f597d25864957c0f04bea7825
> server/src/com/cloud/server/StatsCollector.java
> b4ec9155faf829dd6da14d9aeb79fefb0a257db1
> server/src/com/cloud/vm/UserVmManagerImpl.java
> 6e879161276920c6baf6194fe8a73acec0dd0964
> setup/db/create-schema.sql 79550aee1bb53b9a707eb56911a3186f3475a5d9
> setup/db/db/schema-40to410.sql
> 24f6d4c5e1942232695279ce4dd926e591c4fcd0
>
> Diff: https://reviews.apache.org/r/14628/diff/
>
>
> Testing
> -------
>
> Testing done with some simple scenario. Need help in testing units.
>
>
> Thanks,
>
> tuna
