----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14469/#review26761 -----------------------------------------------------------
1.Can you see make sure that introducing a delay of 3 minutes is actually resulting in all failed test cases to succeed ? There are multiple test cases in this test suite that have failed with the same exception. 2. I see that there are no validation checks done yet for the following tests that are being reported as success: test_05_egress_fr5 test_05_1_egress_fr5 test_08_egress_fr8 test_08_1_egress_fr8 3. For test_03_1_egress_fr3 , expected_result param value is changed from "100" to "0" for exec_script_on_user_vm. In this case documentation says "deploy VM using network offering with egress policy false" , but Vm is deployed with egress_policy=True which is the default. create_vm() should be called with egress_policy=False , to match the changes that is done for expected_result. - sangeetha hariharan On Oct. 3, 2013, 2:33 p.m., Girish Shilamkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14469/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2013, 2:33 p.m.) > > > Review request for cloudstack, Harikrishna Patnala and venkata swamy babu > budumuru. > > > Bugs: CLOUDSTACK-4637 > > > Repository: cloudstack-git > > > Description > ------- > > Add logic to wait for router to boot. > > > Diffs > ----- > > test/integration/component/test_egress_fw_rules.py 5c18f9c > > Diff: https://reviews.apache.org/r/14469/diff/ > > > Testing > ------- > > > Thanks, > > Girish Shilamkar > >
