On Fri, Oct 4, 2013 at 2:17 AM, Anshul Gangwar <anshul.gang...@citrix.com>wrote:
> On Thursday 03 October 2013 08:44 PM, Chip Childers wrote: > > On Thu, Oct 03, 2013 at 11:31:50AM +0000, Anshul Gangwar wrote: > >> Description > >> ------- > >> > >> added the connection and socket timeout parameters for SMTP and sending > message in new thread so that HA doesn't get blocked beacause of hang in > sending email alert > > Wouldn't a better approach be to ensure that email sending runs async to > > critical operations like HA? > > This patch is making email sending async. Currently agent thread first > send the alert( where emails are sent) and then calls the HA. Can you > please elaborate more? Is it logic change or something else? > > Thanks, > Anshul > You're right. I was commenting on the description of the review, but obviously should have looked at the code. LGTM! -chip
