----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14398/#review26603 -----------------------------------------------------------
Ship it! Ship It! - Hugo Trippaers On Sept. 29, 2013, 7:24 a.m., Laszlo Hornyak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14398/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2013, 7:24 a.m.) > > > Review request for cloudstack, daan Hoogland and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > - removed methods that were not used > - parseLong, parseInt and parseFloat replaced with the commons-lang > NumberUtils call > - Test for the remaining methods > > > Diffs > ----- > > utils/src/com/cloud/utils/NumbersUtil.java 035239a > utils/test/com/cloud/utils/NumbersUtilTest.java f60f58a > > Diff: https://reviews.apache.org/r/14398/diff/ > > > Testing > ------- > > tests included > > > Thanks, > > Laszlo Hornyak > >
