----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14119/#review26491 -----------------------------------------------------------
Ship it! Ship It! - Darren Shepherd On Sept. 13, 2013, 6:50 a.m., Darren Shepherd wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14119/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2013, 6:50 a.m.) > > > Review request for cloudstack and Alex Huang. > > > Repository: cloudstack-git > > > Description > ------- > > If your ConfigKey has a default value, the second start of the mgmt server > will result in a NPE when comparing if the persisted default should be updated > > java.lang.NullPointerException > at > org.apache.cloudstack.framework.config.impl.ConfigDepotImpl.populateConfigurations(ConfigDepotImpl.java:103) > at > com.cloud.server.ConfigurationServerImpl.persistDefaultValues(ConfigurationServerImpl.java:294) > at > com.cloud.server.ConfigurationServerImpl.configure(ConfigurationServerImpl.java:147) > > > Diffs > ----- > > > framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java > b516596 > > Diff: https://reviews.apache.org/r/14119/diff/ > > > Testing > ------- > > > Thanks, > > Darren Shepherd > >
