----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14011/#review26470 -----------------------------------------------------------
Ship it! Looks good to me. - Rajesh Battala On Sept. 6, 2013, 8:41 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14011/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2013, 8:41 a.m.) > > > Review request for cloudstack, Devdeep Singh, Fang Wang, and Kelven Yang. > > > Bugs: CLOUDSTACK-4612 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-4612: Specified locale keyboard language is not showing as default > in consoleView passed during deployVM. > > While deploying a VM, user passes the "keyboard" parameter to specify the > default language for that VM but in the consoleView, the default language > selected is en-us irrespective of the default language of the VM. > > > This patch is for 4.2-forward branch. I'll send a seperate patch for master > as there are some conflicts with the master branch. > > > Diffs > ----- > > server/src/com/cloud/servlet/ConsoleProxyClientParam.java e420110 > server/src/com/cloud/servlet/ConsoleProxyServlet.java f6559a5 > services/console-proxy/server/js/ajaxviewer.js 9643204 > > services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java > 6cadeca > > services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java > 07a1b6f > > services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientParam.java > 8de4955 > > services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java > 297e711 > > Diff: https://reviews.apache.org/r/14011/diff/ > > > Testing > ------- > > Verified the fix locally by deploying a VM with keyboard=uk and keyboard=jp. > > > Thanks, > > Sanjay Tripathi > >
