----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14346/ -----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam. Repository: cloudstack-git Description ------- 1. test_snapshot_gc.py : a) Removed the account and vm from cleanup, as we are already deleting account in the test case execution itself. Adding it to cleanup was throwing exception during cleanup operation. b) Once account deleted, listAccount API should fail (as against it should give None) 2. utils.py Changes in "is_snapshot_on_nfs" function: a) Corrected the mount URL, earlier mgt server IP was passed instead of nfs url b) Removed the extra colon between host and dir, colon is already present in the host variable on KVM and VMWare which is correct behaviour. This fails on Xen Sever as the colon is not present. Bug filed for Xen Server >>> https://issues.apache.org/jira/browse/CLOUDSTACK-4741 b) If snapshot not present in db , then return False as the snapshot is not present Diffs ----- test/integration/component/test_snapshot_gc.py aec9761 tools/marvin/marvin/integration/lib/utils.py a6abe06 Diff: https://reviews.apache.org/r/14346/diff/ Testing ------- Thanks, Gaurav Aradhye
