> On Sept. 19, 2013, 4:20 a.m., Abhinandan Prateek wrote: > > Ship It! > > Abhinandan Prateek wrote: > when i try to apply the patch git am says "Patch format detection > failed.". > > Abhinandan Prateek wrote: > Committed ! > > > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=4d01ce8fc766423d795955bd5784b56969ce11a8
reverting it for now as I see build failure, do not have time right now to look for the cause. Will put it back tomorrow. - Abhinandan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14148/#review26261 ----------------------------------------------------------- On Sept. 18, 2013, 5:39 a.m., Darren Shepherd wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14148/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2013, 5:39 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Kelven Yang. > > > Repository: cloudstack-git > > > Description > ------- > > DefaultUserAuthenticator maskes the _name varible in ComponentLifecycleBase > making the setName() method not work as expected. This patch cleans up the > code such that getName() will be getClass().getSimpleName() unless overridden > in the Spring configuration. > > > Diffs > ----- > > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java > e62a3d8 > > plugins/user-authenticators/md5/src/com/cloud/server/auth/MD5UserAuthenticator.java > e5b169f > > plugins/user-authenticators/plain-text/src/com/cloud/server/auth/PlainTextUserAuthenticator.java > f102275 > > plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java > 91be922 > server/src/com/cloud/server/auth/DefaultUserAuthenticator.java 952f724 > > Diff: https://reviews.apache.org/r/14148/diff/ > > > Testing > ------- > > > Thanks, > > Darren Shepherd > >
