-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13701/#review25925
-----------------------------------------------------------



test/integration/component/test_haproxy.py
<https://reviews.apache.org/r/13701/#comment50605>

    can we move configs dictionary to top along with lb_methods?



test/integration/component/test_haproxy.py
<https://reviews.apache.org/r/13701/#comment50606>

    Didn't quite understand what this test is qualifying
    
    - if we create a sticky policy when router is down, we can see the same 
immediately with listLBStickinessPolicies even before the router starts.
    
    - I think the test adds value if we can login to the router and check 
whether the policy is configure once the router is back online.
    



test/integration/component/test_haproxy.py
<https://reviews.apache.org/r/13701/#comment50607>

    destroying a router shouldn't delete the stickiness policy but the 
description says so. Can you confirm whether you saw some behaviour like that?



test/integration/component/test_haproxy.py
<https://reviews.apache.org/r/13701/#comment50608>

    there is no test for #adding same rule again though the doc string says 
there is.


- venkata swamy babu  budumuru


On Aug. 27, 2013, 5:36 a.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13701/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 5:36 a.m.)
> 
> 
> Review request for cloudstack, suresh sadhu and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Automation Tests for HA Proxy Stickiness
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_haproxy.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/13701/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Reply via email to