----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13939/#review25848 -----------------------------------------------------------
if the iterator is Null, then it will return null, Good you had handled the case in the new patch. Joins the elements of the provided array into a single String containing the provided list of elements. No delimiter is added before or after the list. Null objects or empty strings within the array are represented by empty strings. StringUtils.join(null, *) = null StringUtils.join([], *) = "" StringUtils.join([null], *) = "" StringUtils.join(["a", "b", "c"], ';') = "a;b;c" StringUtils.join(["a", "b", "c"], null) = "abc" StringUtils.join([null, "", "a"], ';') = ";;a" - Rajesh Battala On Sept. 3, 2013, 7:21 a.m., Laszlo Hornyak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13939/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2013, 7:21 a.m.) > > > Review request for cloudstack and David Nalley. > > > Repository: cloudstack-git > > > Description > ------- > > - use commons-lang stringutils > - added test to check compatibility > > > Diffs > ----- > > utils/src/com/cloud/utils/StringUtils.java 948c0ac > utils/test/com/cloud/utils/StringUtilsTest.java ae37c24 > > Diff: https://reviews.apache.org/r/13939/diff/ > > > Testing > ------- > > > Thanks, > > Laszlo Hornyak > >
