CIFS support for secondary storage is documented here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/CIFS+Support
The feature was implemented by extending the NFS provider. Its validation was updated so that you can pass it a URL containing the details of a CIFS share. The code that mounts NFS shares was extended to allow it do the same for CIFS shares. Otherwise, the secondary storage code is left unchanged. The source is in the cifs_support branch of https://github.com/lafferty/cloudstack Testing involved running the CIFS-specific and existing NFS tests for the secondary-storage service. E.g. cd ./services/secondary-storage mvn clean install -P developer,systemvm, -DskipTests=false Notice that the pom.xml was updated to allow tests to be turned on using a conditional. I ran the tests on the Citrix network, which allowed the existing NFS tests to run without modification. In addition, an integration test was done exercise the code in the SystemVM environment and to exercise updated validation code. The NFS secondary storage integration test was done using a XenServer deployment in which a template was registered and a VM created from the template. The CIFS secondary storage test was done on a Hyper-V hypervisor a template was registered. Finally, the review request is at https://reviews.apache.org/r/13877/
