----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13821/ -----------------------------------------------------------
Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam. Bugs: CLOUDSTACK-4510 Repository: cloudstack-git Description ------- Moved TestNwOffNetscaler from test_network_offerings to test_netscaler_nw_off since it's more relevant sitting in the latter. Also, it's important that NS scripts run separately with add/remove as part of setup/tearDown since we assume that NS addition/deletion is handled completely by the script itself. Related to this, there are some minor changes in common.py -> add_netscaler to accept NS services directly than the entire services object. Provides more flexibility this way to be able to specify which NS device should be added if we have more than one in the script. Appropriate changes were also done to scripts using add_netscaler Diffs ----- test/integration/component/test_netscaler_lb.py 8375f25 test/integration/component/test_netscaler_lb_algo.py 24c1837 test/integration/component/test_netscaler_lb_sticky.py 7ec85a1 test/integration/component/test_netscaler_nw_off.py 5742f09 test/integration/component/test_network_offering.py e8a7b97 tools/marvin/marvin/integration/lib/common.py 7e8d92d Diff: https://reviews.apache.org/r/13821/diff/ Testing ------- Tested the scripts locally and they are all passing. Thanks, Sowmya Krishnan
