> On Aug. 19, 2013, 11:49 a.m., Sanjay Tripathi wrote: > > test/integration/component/cpu_limits/test_cpu_limits.py, line 526 > > <https://reviews.apache.org/r/13001/diff/3/?file=338932#file338932line526> > > > > As the test title says "reboot_instance" , please use reboot instance > > API instead of stopping and then starting an instance.
Hi Sanjay, According to test scenarios, counts should be checked after stopping, and once again after starting the instance. To avoid the confusion, I will change the test name. > On Aug. 19, 2013, 11:49 a.m., Sanjay Tripathi wrote: > > test/integration/component/cpu_limits/test_domain_limits.py, line 255 > > <https://reviews.apache.org/r/13001/diff/3/?file=338933#file338933line255> > > > > as the test title says "reboot_instance", please use reboot instance > > API. - Gaurav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13001/#review25292 ----------------------------------------------------------- On Aug. 8, 2013, 12:51 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13001/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2013, 12:51 p.m.) > > > Review request for cloudstack, Girish Shilamkar, sailaja mada, Sanjay > Tripathi, and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Adding test cases for CPU limits from Limit Resources. > Marvin changes have to be picked up from Memory Limits patch > (https://reviews.apache.org/r/11626/). Those are not included in this patch. > > > Diffs > ----- > > test/integration/component/cpu_limits/test_cpu_limits.py PRE-CREATION > test/integration/component/cpu_limits/test_domain_limits.py PRE-CREATION > test/integration/component/cpu_limits/test_maximum_limits.py PRE-CREATION > test/integration/component/cpu_limits/test_project_limits.py PRE-CREATION > tools/marvin/marvin/integration/lib/base.py b5d086b > tools/marvin/marvin/integration/lib/common.py 4f5acef > > Diff: https://reviews.apache.org/r/13001/diff/ > > > Testing > ------- > > > Thanks, > > Gaurav Aradhye > >
