----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13615/#review25268 -----------------------------------------------------------
Ship it! 4.2 a03c5f5b1bb3e45b5b2a8365b0c09d48778e426a master bb26b854fb89ef71c22225183e2c23ef17898d9d - Murali Reddy On Aug. 16, 2013, 12:39 p.m., Rajesh Battala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13615/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2013, 12:39 p.m.) > > > Review request for cloudstack, Murali Reddy and Ram Ganesh. > > > Bugs: CLOUDSTACK-4237 > > > Repository: cloudstack-git > > > Description > ------- > > Issue: > for an account if there are multiple LB rules and Autoscale Policies, when > Account is deleted. All the LBrules, Autoscale polices are not getting delete > in Netscaler resource. But in CS db they are getting cleared. > > Root Cause: > =========== > while processing the LBConfigcmd in NSResource, after processing the first > Autoscale cmd, no other rules are getting processed as its returning from > loop. > > Fix: > ==== > > Fixed the issue to process all the autoscale config rules in the > LBConfigCommand. > > > Diffs > ----- > > > plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java > 4020059 > > Diff: https://reviews.apache.org/r/13615/diff/ > > > Testing > ------- > > 1. created a testA account and created network with NS as LB provider and > Acquired 3 ip's > 2. on each IP configured multiple Autoscale polices and normal LB rules. > 3. Verified on NS there are total 4 vservers and 3 services ( 2 autoscale and > 2 cloud service) > 4. deleted one LB rule. LB rule got delete successfully and the same is > removed from NS. > 5. deleted the account, network got deleted as part of it all the rules got > revoked and sent to NSResource to execute them. > All the servers, lb vservers got remove successfully. > > > Thanks, > > Rajesh Battala > >
