----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13523/#review25146 -----------------------------------------------------------
test/integration/component/test_affinity_groups.py <https://reviews.apache.org/r/13523/#comment49370> I didn't quite understand this assert. What hostid are we talking about? test/integration/component/test_affinity_groups.py <https://reviews.apache.org/r/13523/#comment49371> Can we be explicit? "Missing affinity group %s .." test/integration/component/test_affinity_groups.py <https://reviews.apache.org/r/13523/#comment49373> remove multihost tag test/integration/component/test_affinity_groups.py <https://reviews.apache.org/r/13523/#comment49377> "%s affinity groups listed by admin with id %s. Expected 1" % (count, id) ^ This is much better for debugging and takes the form of expected against observed. test/integration/component/test_affinity_groups.py <https://reviews.apache.org/r/13523/#comment49378> Improve the assertion to show expected vs observed. - Prasanna Santhanam On Aug. 13, 2013, 4:40 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13523/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2013, 4:40 a.m.) > > > Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > New tests for affinity groups > > > Diffs > ----- > > test/integration/component/test_affinity_groups.py 39baf3e > > Diff: https://reviews.apache.org/r/13523/diff/ > > > Testing > ------- > > > Thanks, > > Ashutosh Kelkar > >
