----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13134/#review24899 -----------------------------------------------------------
Ship it! This patch looks good to me. Brian, could you please merge this patch ? - Pranav Saxena On Aug. 2, 2013, 1:37 p.m., Chris Suich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13134/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2013, 1:37 p.m.) > > > Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena. > > > Repository: cloudstack-git > > > Description > ------- > > I have added a new dialog field type called 'has_units'. This field has an > input box side by side with a select box. The select box is populated with > predefined units (MB, GB, TB, for example) and uses (also predefined) > conversion functions to allow automatic updating of the input box value when > the units select box is changed. > > For some reason, it says that ui/scripts/ui/dialog.js can not be found in the > repository, so I have added the patch file manually. Please let me know if > there is some way to fix this. > > > Diffs > ----- > > > Diff: https://reviews.apache.org/r/13134/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > > > https://reviews.apache.org/media/uploaded/files/2013/07/31/has_units-field.patch > > > Thanks, > > Chris Suich > >
