----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13377/#review24873 -----------------------------------------------------------
Ship it! - Prasanna Santhanam On Aug. 7, 2013, 4:18 p.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13377/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2013, 4:18 p.m.) > > > Review request for cloudstack, Devdeep Singh and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-4021 > > > Repository: cloudstack-git > > > Description > ------- > > Test case > "integration.component.test_explicit_dedication.TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication" > fails if it does not find an empty hosts. > In case there is at least 1 empty host present, that host is dedicated and a > vm is deployed using explicit dedication affinity group. > Added check that skips the test in case there are no empty hosts found. > > > Diffs > ----- > > test/integration/component/test_explicit_dedication.py e1991ac > > Diff: https://reviews.apache.org/r/13377/diff/ > > > Testing > ------- > > If there are no empty hosts present, the test returns without further > dedication or deploying vms. > If there is a single empty host present, the host is dedicated and vm is > deployed. > > > Thanks, > > Saksham Srivastava > >
