So is the difference between test and integration-test is that the code access db? I've noticed a great deal of test code that's been disabled by hand as well. A proper test should just mock the db layer.
To me it would make sense if we use an in memory db like derby for the unit tests. --Alex > -----Original Message----- > From: Min Chen [mailto:min.c...@citrix.com] > Sent: Tuesday, August 6, 2013 3:58 PM > To: dev@cloudstack.apache.org > Subject: Re: TEST or integration test? > > For /engine/storage/integration-test, I know that those tests are TestNG > test cases, requiring DB existence. > > Thanks > -min > > On 8/6/13 2:59 PM, "Alex Huang" <alex.hu...@citrix.com> wrote: > > >I noticed that some of our unit tests are run in integration-test stage > >of maven. Shouldn't that be in the test phase? Does anyone know why > >it's set at integration-test? I based this observation on the surefire > >plugins are set for integration-test phase. Note the following. > > > >./engine/orchestration/pom.xml- <phase>integration-test</phase> > >./engine/storage/integration-test/pom.xml- > ><phase>integration-test</phase> > >./engine/storage/volume/pom.xml- > ><phase>integration-test</phase> > >./plugins/storage/image/default/pom.xml- > ><phase>integration-test</phase> > >./plugins/storage/image/sample/pom.xml- > ><phase>integration-test</phase> > >./plugins/storage/image/swift/pom.xml- > ><phase>integration-test</phase> > >./plugins/storage/volume/default/pom.xml- > ><phase>integration-test</phase> > >./plugins/storage/volume/sample/pom.xml- > ><phase>integration-test</phase> > >./plugins/storage/volume/solidfire/pom.xml- > ><phase>integration-test</phase> > > > >I think integration test is probably just the smoke test that Prasanna > >has written. We should enforce that in the maven build. Does that > >make sense? > > > >--Alex
