> On Aug. 5, 2013, 9:55 a.m., Jayapal Reddy wrote: > > test/integration/component/test_egress_fw_rules.py, line 27 > > <https://reviews.apache.org/r/12934/diff/5/?file=336941#file336941line27> > > > > remove the white space (red colour). > > Please apply the patch in your local and make sure there is no warning. > > # git apply patchName.patch
Removed the trailing white space. > On Aug. 5, 2013, 9:55 a.m., Jayapal Reddy wrote: > > test/integration/component/test_egress_fw_rules.py, line 108 > > <https://reviews.apache.org/r/12934/diff/5/?file=336941#file336941line108> > > > > do we need specify vlan here ? No need to specify the VLAN ID here. > On Aug. 5, 2013, 9:55 a.m., Jayapal Reddy wrote: > > test/integration/component/test_egress_fw_rules.py, line 130 > > <https://reviews.apache.org/r/12934/diff/5/?file=336941#file336941line130> > > > > Hard coding vlan may not work for others setups. > > If specify vlan is set then query the free vlan id Removed VLAN ID value from service data. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12934/#review24640 ----------------------------------------------------------- On Aug. 1, 2013, 6:19 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12934/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2013, 6:19 a.m.) > > > Review request for cloudstack, Girish Shilamkar, Jayapal Reddy, and Prasanna > Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Tests for egress firewall rules for advance zone. > > > Diffs > ----- > > test/integration/component/test_egress_fw_rules.py PRE-CREATION > > Diff: https://reviews.apache.org/r/12934/diff/ > > > Testing > ------- > > > Thanks, > > Ashutosh Kelkar > >
