> On July 30, 2013, 2:41 p.m., Prasanna Santhanam wrote: > > test/integration/smoke/test_internal_lb.py, line 116 > > <https://reviews.apache.org/r/13055/diff/1/?file=330476#file330476line116> > > > > we should not use the ids to list. How about list the vpcoffering based > > on the name? and then use the returned uuid.
Filtering it using 'isdefault=true' > On July 30, 2013, 2:41 p.m., Prasanna Santhanam wrote: > > test/integration/smoke/test_network_acl.py, line 112 > > <https://reviews.apache.org/r/13055/diff/1/?file=330477#file330477line112> > > > > we should not use the ids to list. How about list the vpcoffering based > > on the name? and then use the returned uuid. Filtering it using 'isdefault=true' - SrikanteswaraRao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13055/#review24234 ----------------------------------------------------------- On July 30, 2013, 6:51 a.m., SrikanteswaraRao Talluri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13055/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 6:51 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru and Prasanna > Santhanam. > > > Bugs: CLOUDSTACK-3923 > > > Repository: cloudstack-git > > > Description > ------- > > When there are multiple VPC offerings, test is failing because list VPC > offering is listing multiple vpc offerings. > > Test requires to select the default VPC offering which has lb service as > internal LB which has id=1. > > fix is to select vpc offering with id=1 > > > Diffs > ----- > > test/integration/smoke/test_internal_lb.py 0535d6a > test/integration/smoke/test_network_acl.py 4b3c1f7 > > Diff: https://reviews.apache.org/r/13055/diff/ > > > Testing > ------- > > tested. > > > Thanks, > > SrikanteswaraRao Talluri > >
